Skip to content

Comments

chore: transactional ContextDataManager in prep for FDv2#322

Open
tanderson-ld wants to merge 3 commits intomainfrom
ta/SDK-1817/composite-source-pt1
Open

chore: transactional ContextDataManager in prep for FDv2#322
tanderson-ld wants to merge 3 commits intomainfrom
ta/SDK-1817/composite-source-pt1

Conversation

@tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Feb 18, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues
SDK-1817


Note

Medium Risk
Touches core flag update/persistence and listener-notification paths; bugs could cause missed/extra updates or incorrect cached flag state, though changes are well-covered by new unit tests.

Overview
Prepares the Android SDK’s flag store for FDv2 by introducing transactional updates via new ChangeSet/ChangeSetType models and TransactionalDataStore/TransactionalDataSourceUpdateSink interfaces.

ContextDataManager now applies updates as full replace, partial merge (version-respecting), or no-op, optionally persists the result, and tracks an in-memory FDv2 Selector for subsequent requests (cleared when Selector.EMPTY is applied). ConnectivityManager’s sink and shared test mocks are updated to implement DataSourceUpdateSinkV2 and forward apply() calls, with new unit tests validating the new semantics; shared test code adds a dependency on launchdarkly-java-sdk-internal for Selector.

Written by Cursor Bugbot for commit 15d05ff. This will update automatically on new commits. Configure here.

@tanderson-ld tanderson-ld marked this pull request as ready for review February 19, 2026 14:33
@tanderson-ld tanderson-ld requested a review from a team as a code owner February 19, 2026 14:33
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants