chore: transactional ContextDataManager in prep for FDv2#322
Open
tanderson-ld wants to merge 3 commits intomainfrom
Open
chore: transactional ContextDataManager in prep for FDv2#322tanderson-ld wants to merge 3 commits intomainfrom
tanderson-ld wants to merge 3 commits intomainfrom
Conversation
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Outdated
Show resolved
Hide resolved
joker23
reviewed
Feb 19, 2026
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Show resolved
Hide resolved
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Show resolved
Hide resolved
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Show resolved
Hide resolved
kinyoklion
reviewed
Feb 19, 2026
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
Feb 19, 2026
...darkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/ContextDataManager.java
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
Feb 19, 2026
...rkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/subsystems/ChangeSet.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
SDK-1817
Note
Medium Risk
Touches core flag update/persistence and listener-notification paths; bugs could cause missed/extra updates or incorrect cached flag state, though changes are well-covered by new unit tests.
Overview
Prepares the Android SDK’s flag store for FDv2 by introducing transactional updates via new
ChangeSet/ChangeSetTypemodels andTransactionalDataStore/TransactionalDataSourceUpdateSinkinterfaces.ContextDataManagernow applies updates as full replace, partial merge (version-respecting), or no-op, optionally persists the result, and tracks an in-memory FDv2Selectorfor subsequent requests (cleared whenSelector.EMPTYis applied).ConnectivityManager’s sink and shared test mocks are updated to implementDataSourceUpdateSinkV2and forwardapply()calls, with new unit tests validating the new semantics; shared test code adds a dependency onlaunchdarkly-java-sdk-internalforSelector.Written by Cursor Bugbot for commit 15d05ff. This will update automatically on new commits. Configure here.